-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PR :: Exception 관련 필터를 SecurityFilterChain에서 분리 #184
Merged
HyunSu1768
merged 10 commits into
develop
from
BAC-520-Exception-관련--필터를-SecurityFilterChain에서-분리
Mar 24, 2024
The head ref may contain hidden characters: "BAC-520-Exception-\uAD00\uB828--\uD544\uD130\uB97C-SecurityFilterChain\uC5D0\uC11C-\uBD84\uB9AC"
Merged
PR :: Exception 관련 필터를 SecurityFilterChain에서 분리 #184
HyunSu1768
merged 10 commits into
develop
from
BAC-520-Exception-관련--필터를-SecurityFilterChain에서-분리
Mar 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maeumgagym-ci-robot-app
bot
added
kind/리펙토링
refactoring code
kind/기능
functional development
size/L
labels
Mar 22, 2024
/hold |
/unhold |
1 similar comment
/unhold |
/tide |
1 similar comment
/tide |
/lgtm |
HyunSu1768
deleted the
BAC-520-Exception-관련--필터를-SecurityFilterChain에서-분리
branch
March 24, 2024 07:58
HyunSu1768
restored the
BAC-520-Exception-관련--필터를-SecurityFilterChain에서-분리
branch
March 24, 2024 07:58
HyunSu1768
deleted the
BAC-520-Exception-관련--필터를-SecurityFilterChain에서-분리
branch
March 24, 2024 07:58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
어떤 종류의 PR 인가요?
/kind 리펙토링
/kind 기능
이 PR이 무슨 일을 하나요? / 필요한 이유가 뭔가요?
이전에 생성한 ExceptionConvertFilter, ErrorLogResponseFilter를 원래는 ApplicationFilterChain에 등록해 SecurityFilterChain과 독립되어야 했으나, 구현의 어려움으로 인해 임시적으로 SecurityFilterChain에 등록했습니다.
논리적으로 문제는 없으나, 이는 개발자가 보기에는 분리되어야 할, 서로 관계 없는 책임이 결합되어있는 형태로 보여, 다소 거슬리는, 오리알과 같은 신세였습니다.
그리고 지금, Exception과 관련한 Filter들을 드디어 분리해내어 ApplicationFilterChain에서 실행되도록 만들었습니다.
또한 이를 뒤따라 SecurityFilterChain, 그리고 FilterChainProxy로부터 영감을 받아 추상화된 모듈인 GlobalFilterChain, GlobalFilterChainProxy, ChainedFilterChain, ChainedFilterChainProxy를 제작하게 되었습니다.
이 덕분에 더욱 응집되어 있고 더욱 느슨하게 결합되도록 유지할 수 있게 하였습니다.
리뷰어를 위한 참고사항: